E&S CVS Commit: PEAK - Fixed "silent failure" of component constructors when invalid keyword

pje at eby-sarna.com pje at eby-sarna.com
Sun Dec 8 17:33:00 EST 2002

Module Name:	PEAK
Committed By:	pje
Date:		Sun Dec  8 22:32:15 UTC 2002

Modified Files:
	PEAK/src/peak/binding: components.py
	PEAK/src/peak/binding/tests: __init__.py
	PEAK/src/peak/storage: connections.py

Log Message:
Fixed "silent failure" of component constructors when invalid keyword
arguments are supplied, and managed connections breaking because they
didn't have an 'address' attribute.  The first bug was masking the second,
at least from the point of view of our tests.  This bug has been in here
since I added keyword "validation", but wasn't caught because we evidently
haven't tried to use any connection objects since.  We really need some
extra tests that actually connect to databases, LDAP, etc., so that we can
prevent regressions like this.  :(

To view diffs of this commit, you can use the following URL(s):

To generate a diff of this commit:
cvs rdiff -r1.76 -r1.77 PEAK/src/peak/binding/components.py
cvs rdiff -r1.22 -r1.23 PEAK/src/peak/binding/tests/__init__.py
cvs rdiff -r1.12 -r1.13 PEAK/src/peak/storage/connections.py

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

More information about the source-changes mailing list